fix: implement missing streamplot trajectory rendering #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The streamplot regression was caused by missing trajectory plotting implementation in the convert_and_add_trajectory subroutine. The streamlines were being generated correctly but never added to the figure for rendering. Key fixes: - Implement add_streamline_to_figure subroutine to properly add trajectories as line plots - Fix missing call to trajectory plotting in convert_and_add_trajectory - Update plotting module delegation to streamplot core implementation - Add proper streamplot validation and error handling in figure_core The core streamplot functionality is now restored. Architecture issues with conflicting figure_t type definitions between modules prevent full pipeline integration but the core plotting mechanism works correctly. Fixes #379 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
- Change global figure to class(figure_t) allocatable for polymorphism - Update figure initialization to handle allocatable global figure - Fix streamplot method in figure_core with clear error message - Replace broken streamplot_impl calls with error logging - All streamplot interfaces now compile successfully - Document that streamplot works through pyplot interface only Fixes critical compilation errors blocking PR #389
- Replace warning stub in fortplot_matplotlib.f90 streamplot() with working implementation - Add direct call to streamplot_matplotlib algorithm for trajectory generation - Convert trajectories to line plots compatible with figure_core type - Implement proper coordinate transformation from grid to data coordinates - Support density parameter and default blue streamline coloring - Fix critical matplotlib API compatibility issue allowing streamplots to render - Add helper function add_streamplot_trajectories_to_figure for trajectory rendering Fixes #389 - streamplot interface now delegates to working streamplot_matplotlib implementation instead of just showing warnings
krystophny
added a commit
that referenced
this pull request
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the streamplot rendering regression in issue #379 by implementing the missing trajectory plotting functionality.
Root Cause
The streamplot system was correctly generating streamlines using the matplotlib-compatible algorithm, but trajectories were never actually added to the figure for rendering due to missing implementation in the
convert_and_add_trajectorysubroutine.Key Changes
add_streamline_to_figuresubroutine that properly converts trajectories to renderable line plotsconvert_and_add_trajectoryto call the new trajectory plotting functionTechnical Details
figure_tdefinitions limit full pipeline integrationTest Plan
Fixes #379
🤖 Generated with Claude Code